[PATCH] D33229: [BinaryStream] Simplify the process of using BinaryStreams

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 09:56:48 PDT 2017


zturner added a reviewer: amccarth.
zturner added a comment.

+amccarth since he's used some of this stuff before too.

Also, in case it's not obvious, I included the changes to `COFFDumper` as an example of how it can simplify code (see especially the part where i no longer have to hold a copy of a `BinaryStreamRef` inside of a class.

The only real downside to this patch is that all instances of `BinaryStreamRef` become larger by `sizeof(std::shared_ptr<T>)`, and we frequently pass them by value.  But that seems somewhat minor.


https://reviews.llvm.org/D33229





More information about the llvm-commits mailing list