[PATCH] D33056: [NewGVN] When a store becomes the leader, update the memory leader for the class

[Daniel Berlin via llvm-commits]

By definition, if empty () is true, store count must be zero (empty means
there are no real Value's in the class, stores or otherwise)
We assert this in congruence class moving.


On Thu, May 11, 2017, 3:14 PM Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide added a comment.
>
> While looking at something completely unrelated I noticed:
>
>   bool isDead() const {
>     // If it's both dead from a value perspective, and dead from a memory
>     // perspective, it's really dead.
>     return empty() && memory_empty();
>   }
>
> shouldn't this also do `&& StoreCount == 0` ?
>
>
> https://reviews.llvm.org/D33056
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170511/68ec979c/attachment.html>