[PATCH] D33056: [NewGVN] When a store becomes the leader, update the memory leader for the class

[Davide Italiano via llvm-commits]

Oh, yes. Can we land this one then I assume?

On Thu, May 11, 2017 at 2:20 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
> By definition, if empty () is true, store count must be zero (empty means
> there are no real Value's in the class, stores or otherwise)
> We assert this in congruence class moving.
>
>
> On Thu, May 11, 2017, 3:14 PM Davide Italiano via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> davide added a comment.
>>
>> While looking at something completely unrelated I noticed:
>>
>>   bool isDead() const {
>>     // If it's both dead from a value perspective, and dead from a memory
>>     // perspective, it's really dead.
>>     return empty() && memory_empty();
>>   }
>>
>> shouldn't this also do `&& StoreCount == 0` ?
>>
>>
>> https://reviews.llvm.org/D33056
>>
>>
>>
>