[PATCH] D33007: [scudo] Use our own combined allocator

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added a comment.

In https://reviews.llvm.org/D33007#751634, @alekseyshl wrote:

> I do not like the code duplication and all those UNIMPLEMENTED in ScudoCombinedAllocator and around, it's hard to reason why there's so much unused API (why is it declared then?) Also I expected to see some simplification in CombinedAllocator<>, none was necessary, maybe it means that CombinedAllocator has some potential for improvement, to be more flexible to address Scudo needs?


It's fair. I'll send out a revision removing all the unneeded code from the combined and the secondary.
As for modifying the original combined, I do not think it's doable without a significant increase in complexity and branches, which is what I am trying to get rid of.
A lot of the difference comes from the fact that the frontend of the other sanitizers defer a lot to the original combined (alignment, realloc, memset, etc), while our frontend does all that work.


https://reviews.llvm.org/D33007