[PATCH] D33007: [scudo] Use our own combined allocator

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 15:28:30 PDT 2017


alekseyshl added a comment.

I do not like the code duplication and all those UNIMPLEMENTED in ScudoCombinedAllocator and around, it's hard to reason why there's so much unused API (why is it declared then?) Also I expected to see some simplification in CombinedAllocator<>, none was necessary, maybe it means that CombinedAllocator has some potential for improvement, to be more flexible to address Scudo needs?

All that said, 3% performance gain is too big to pass on, if CombinedAllocator is not possible or too complicated to adjust for Scudo, I'm ok with this change.


https://reviews.llvm.org/D33007





More information about the llvm-commits mailing list