[PATCH] D32737: [Constants][SVE] Represent the runtime length of a scalable vector

[Graham Hunter via Phabricator via llvm-commits]

huntergr added inline comments.


================
Comment at: include/llvm-c/Core.h:1188
       macro(UndefValue)                     \
+      macro(VScaleValue)                    \
     macro(Instruction)                      \
----------------
rengolin wrote:
> Not being in the same order as above may confuse people looking for it?
These are already in a different order than the enum above -- Undef appears before ConstantInt there, but after it here. The indentation and the comment above it suggest a hierarchy, so I tried following that.


================
Comment at: include/llvm/IR/Value.def:92
 HANDLE_CONSTANT_MARKER(ConstantFirstVal, Function)
-HANDLE_CONSTANT_MARKER(ConstantLastVal, ConstantTokenNone)
+HANDLE_CONSTANT_MARKER(ConstantLastVal, VScaleValue)
 HANDLE_CONSTANT_MARKER(ConstantDataFirstVal, UndefValue)
----------------
rengolin wrote:
> I don't get this change...
I added it at the end, after 'ConstantTokenNone', so needed to adjust the last marker. Since this isn't part of the C interface, I could add it before this and not need to change the markers.


https://reviews.llvm.org/D32737