[PATCH] D32737: [Constants][SVE] Represent the runtime length of a scalable vector

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: lib/IR/Constants.cpp:802
+  std::unique_ptr<VScaleValue> &Entry =
+  Ty->getContext().pImpl->VSVConstants[Ty];
+  if (!Entry)
----------------
Indentation.


================
Comment at: lib/IR/Constants.cpp:812
+  // Free the constant and any dangling references to it.
+  getContext().pImpl->VSVConstants.erase(getType());
+}
----------------
rengolin wrote:
> So, in theory, you can have vscale constans of different integer types, and this would only clear the ones that are the same as this one? 
> 
> This sounds confusing.
Yes, in the same way you can have i32 undef, i64 undef etc.


https://reviews.llvm.org/D32737