[PATCH] D31787: [TLI] Add declarations for various math header file routines from math-finite.h that create '__<func>_finite as functions

Chris Chrulski via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 18:12:52 PDT 2017


> Beyond that, I'm curious: should these be added as names only, and treated as "aliases" of the non-finite functions (only when -ffinite-math-only) ? Or, put another way: is it ever desirable to distinguish between them?
 Is there existing support in the TLI functionality to support aliased names? Or do you mean new functionality should be created?
The case that I think may be useful in the future to distinguish between them is if there were to be vector versions of the functions that could replace the call, which were optimized differently depending on whether the values are known to be finite or now. 
Thanks,Chris


    On Tuesday, May 2, 2017 3:28 PM, Chris Chrulski via Phabricator <reviews at reviews.llvm.org> wrote:
 

 chrischr updated this revision to Diff 97511.
chrischr added a comment.

New version uploaded which adds changes to the unit test files in test/Transformas/InferFnctionAttrs to include the newly added TLI function prototypes.


https://reviews.llvm.org/D31787

Files:
  include/llvm/Analysis/TargetLibraryInfo.def
  lib/Analysis/TargetLibraryInfo.cpp
  test/Transforms/InferFunctionAttrs/annotate.ll
  test/Transforms/InferFunctionAttrs/no-proto.ll
  unittests/Analysis/TargetLibraryInfoTest.cpp


   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170503/1b8cc0a6/attachment.html>


More information about the llvm-commits mailing list