<html><head></head><body><div style="color:#000; background-color:#fff; font-family:Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:13px"><div id="yui_3_16_0_ym19_1_1493773170085_3014" dir="ltr"><span style="font-family: "Segoe UI", "Segoe UI Emoji", "Segoe UI Symbol", Lato, "Helvetica Neue", Helvetica, Arial, sans-serif;" id="yui_3_16_0_ym19_1_1493773170085_3084">> Beyond that, I'm curious: should these be added as names only, and treated as "aliases" of the non-finite functions (only when -ffinite-math-only) ? Or, put another way: is it ever desirable to distinguish between them?</span><span></span></div><div id="yui_3_16_0_ym19_1_1493773170085_3014" dir="ltr"><span style="font-family: "Segoe UI", "Segoe UI Emoji", "Segoe UI Symbol", Lato, "Helvetica Neue", Helvetica, Arial, sans-serif;"><br></span></div> <div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr">Is there existing support in the TLI functionality to support aliased names? Or do you mean new functionality should be created?</div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr"><br></div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr">The case that I think may be useful in the future to distinguish between them is if there were to be vector versions of the functions that could replace the call, which were optimized differently depending on whether the values are </div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr">known to be finite or now. </div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr"><br></div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr">Thanks,</div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr">Chris</div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034" dir="ltr"><br></div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1493773170085_3034"><br><br></div><div class="yahoo_quoted" id="yui_3_16_0_ym19_1_1493773170085_3033" style="display: block;"> <div style="font-family: Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 13px;" id="yui_3_16_0_ym19_1_1493773170085_3032"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;" id="yui_3_16_0_ym19_1_1493773170085_3031"> <div dir="ltr" id="yui_3_16_0_ym19_1_1493773170085_3036"><font size="2" face="Arial" id="yui_3_16_0_ym19_1_1493773170085_3035"> On Tuesday, May 2, 2017 3:28 PM, Chris Chrulski via Phabricator <reviews@reviews.llvm.org> wrote:<br></font></div> <br><br> <div class="y_msg_container" id="yui_3_16_0_ym19_1_1493773170085_3030"><div dir="ltr" id="yui_3_16_0_ym19_1_1493773170085_3029">chrischr updated this revision to Diff 97511.<br clear="none">chrischr added a comment.<br clear="none"><br clear="none">New version uploaded which adds changes to the unit test files in test/Transformas/InferFnctionAttrs to include the newly added TLI function prototypes.<br clear="none"><br clear="none"><br clear="none"><a shape="rect" href="https://reviews.llvm.org/D31787" target="_blank">https://reviews.llvm.org/D31787</a><br clear="none"><br clear="none">Files:<br clear="none"> include/llvm/Analysis/TargetLibraryInfo.def<br clear="none"> lib/Analysis/TargetLibraryInfo.cpp<br clear="none"> test/Transforms/InferFunctionAttrs/annotate.ll<br clear="none"> test/Transforms/InferFunctionAttrs/no-proto.ll<div class="yqt0526564589" id="yqtfd06932"><br clear="none"> unittests/Analysis/TargetLibraryInfoTest.cpp<br clear="none"></div></div><br><br></div> </div> </div> </div></div></body></html>