[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/Object/DEFParser.cpp:57-58
+
+static BumpPtrAllocator BAlloc;
+static StringSaver Saver{BAlloc};
+
----------------
martell wrote:
> ruiu wrote:
> > martell wrote:
> > > ruiu wrote:
> > > > Remove.
> > > How would you suggest I allocate the StringRef when decorating `E.Name` and `E.ExtName`?
> > Maybe just by making `E.Name` and `E.ExtName` be std::string instead of StringRef?
> Whoa that was a fast reply. :)
> Will I also change `SymbolName` to `std::string` for the consistency of `COFFShortExport`?
I have no strong preference, but well, if I'd write this, I believe I'd probably make it std::string as we don't need to be picky about memory consumption here.


Repository:
  rL LLVM

https://reviews.llvm.org/D32689