[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Martell Malone via Phabricator via llvm-commits]

martell added inline comments.


================
Comment at: lib/Object/DEFParser.cpp:57-58
+
+static BumpPtrAllocator BAlloc;
+static StringSaver Saver{BAlloc};
+
----------------
ruiu wrote:
> martell wrote:
> > ruiu wrote:
> > > Remove.
> > How would you suggest I allocate the StringRef when decorating `E.Name` and `E.ExtName`?
> Maybe just by making `E.Name` and `E.ExtName` be std::string instead of StringRef?
Whoa that was a fast reply. :)
Will I also change `SymbolName` to `std::string` for the consistency of `COFFShortExport`?


Repository:
  rL LLVM

https://reviews.llvm.org/D32689