[PATCH] D32720: [LICM] Introduce a finer granularity option to compute early exits.

[Xin Tong via Phabricator via llvm-commits]

trentxintong added inline comments.


================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:60
+  // Map to speed up instruction dominance check.
+  DenseMap<const BasicBlock *, std::unique_ptr<OrderedBasicBlock>> OBBMap;
+
----------------
dberlin wrote:
> Would it trouble you too much to move this OBBMAP into Transforms/Utils as a class called "OrderedInstructions" or something.
> 
> (IE provides a dominates call, handles calling dt->dominates if they are in different bbs, or checking ordering if they are in the same bb?)
>  
> We should encapsulate this.
> 
> I'm happy to clean up the existing users if you are willing to encapsulate it :)
I am thinking about that as well. I will do it 


https://reviews.llvm.org/D32720