[PATCH] D32720: [LICM] Introduce a finer granularity option to compute early exits.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 16:23:46 PDT 2017


dberlin added inline comments.


================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:60
+  // Map to speed up instruction dominance check.
+  DenseMap<const BasicBlock *, std::unique_ptr<OrderedBasicBlock>> OBBMap;
+
----------------
Would it trouble you too much to move this OBBMAP into Transforms/Utils as a class called "OrderedInstructions" or something.

(IE provides a dominates call, handles calling dt->dominates if they are in different bbs, or checking ordering if they are in the same bb?)
 
We should encapsulate this.

I'm happy to clean up the existing users if you are willing to encapsulate it :)


https://reviews.llvm.org/D32720





More information about the llvm-commits mailing list