[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 09:38:40 PDT 2017


mehdi_amini added inline comments.


================
Comment at: lib/Support/DEFParser.cpp:42
+BumpPtrAllocator BAlloc;
+StringSaver Saver{BAlloc};
+
----------------
These global variables don't fit the way LLVMN libraries are design, but I may lack context here, can you comment on this?


Repository:
  rL LLVM

https://reviews.llvm.org/D32689





More information about the llvm-commits mailing list