[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Martell Malone via Phabricator via llvm-commits]

martell added a comment.

In https://reviews.llvm.org/D32689#741974, @ruiu wrote:

> Since Librarian.cpp provides a different feather than those in COFFImportFile.h, you want to create a new header file, even if it means you'll end up creating a header file declaring only one function.


Hey Rui,
Could you elaborate a little. For context I don't quite understand the meaning of feather here.
My current understanding is that the 2 functions we need to expose are `parseModuleDefs` and `writeImportLibrary` which moved from `ModuleDef` to `DefParser` and from `ModuleDef` to `COFFImportFile` respectively.



================
Comment at: include/llvm/Object/COFFImportFile.h:84
+
+  bool operator==(const COFFShortExport &E) {
+    return (Name == E.Name && ExtName == E.ExtName &&
----------------
dberris wrote:
> This probably should be a non-member friend function, and have an `operator !=(...)` overload as well.
Will do this for the next revision. Thanks for the feedback


Repository:
  rL LLVM

https://reviews.llvm.org/D32689