[PATCH] D32527: Generalize flag carrying SDNodes beyond binary ops. NFC.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:429-431
+  void intersectWith(const SDNodeFlags Flags) {
+    if (!Flags.isDefined())
+      return;
----------------
spatel wrote:
> Do we also need to check that 'this' struct isDefined?
>   if (!AnyDefined)
>     return;
> 
> Or are the flags guaranteed defined for whatever node is making this call?
The intersection can only zero out bits, and if the current flags aren't defined then this operation won't have any effect since they're already zero.


Repository:
  rL LLVM

https://reviews.llvm.org/D32527