[PATCH] D32527: Generalize flag carrying SDNodes beyond binary ops. NFC.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 15:43:14 PDT 2017


spatel added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:429-431
+  void intersectWith(const SDNodeFlags Flags) {
+    if (!Flags.isDefined())
+      return;
----------------
Do we also need to check that 'this' struct isDefined?
  if (!AnyDefined)
    return;

Or are the flags guaranteed defined for whatever node is making this call?


Repository:
  rL LLVM

https://reviews.llvm.org/D32527





More information about the llvm-commits mailing list