[PATCH] D32541: Supress all uses of LLVM_END_WITH_NULL

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 12:39:15 PDT 2017


serge-sans-paille added inline comments.


================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:479
         PointerType::getUnqual(
-            FunctionType::get(PointerType::getUnqual(ArgTLSTy),
-                              (Type *)nullptr)));
+            FunctionType::get(PointerType::getUnqual(ArgTLSTy), false)));
   }
----------------
mehdi_amini wrote:
> Why do you need the false here?
That's not related to this commit. the function signature is : ``static FunctionType * 	get (const Type *Result, bool isVarArg)`` so passing a casted null pointer was indeed working, but that's not very explicit :-/


Repository:
  rL LLVM

https://reviews.llvm.org/D32541





More information about the llvm-commits mailing list