[PATCH] D32541: Supress all uses of LLVM_END_WITH_NULL
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 26 12:05:02 PDT 2017
mehdi_amini added a comment.
In https://reviews.llvm.org/D32541#738248, @serge-sans-paille wrote:
> Note: I also have a patch to apply to clang because of the API chagne. What's the policy for cross-repo commits?
Informal Policy is: you should update it, at least when it is about clang (a large part of the CI testing is bootstrapping the compiler).
(Side Note: this setup helps to do it atomically in one review / one commit : http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo )
================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:479
PointerType::getUnqual(
- FunctionType::get(PointerType::getUnqual(ArgTLSTy),
- (Type *)nullptr)));
+ FunctionType::get(PointerType::getUnqual(ArgTLSTy), false)));
}
----------------
Why do you need the false here?
Repository:
rL LLVM
https://reviews.llvm.org/D32541
More information about the llvm-commits
mailing list