[PATCH] D32404: [LV] Make LIT test insensitive to basic block numbering

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 07:16:01 PDT 2017


gilr added a comment.

Hi Matt,

In https://reviews.llvm.org/D32404#735452, @mssimpso wrote:

> I've seen this convention in other tests, and it would further harden the test to potential name changes.


So I was asking myself the same question while doing this. I ended up keeping the hard-coded names since they carry a meaning (similar to vector.body) and can actually make the test more robust while OTOH BB name schemes don't change so often. But we should indeed try to keep it consistent across all LITs one way or the other (interleaved-accesses-pred-stores also seems to hard-code the names). **Michael**, what do you think?
Since this patch is part of the vplan breakdown I'll commit it as-is (to clarify that the VPlan patch only affects the numbering) and will follow up in a separate patch to unify the behavior across all LITs to what ever pattern we converge to.


https://reviews.llvm.org/D32404





More information about the llvm-commits mailing list