[PATCH] D32404: [LV] Make LIT test insensitive to basic block numbering

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 08:34:54 PDT 2017


mssimpso accepted this revision.
mssimpso added a comment.
This revision is now accepted and ready to land.

Hi Gil,

While you're working on this, I wonder if you wouldn't mind going further and just making the block names themselves match the regex? Something like:

  vector.body:
    %index = phi i32 [ 0, %vector.ph ], [ %index.next, %[[PRED_UDIV_CONTINUE:.+]] ]
    ...
  [[PRED_UDIV_CONTINUE]]:
    ...

I've seen this convention in other tests, and it would further harden the test to potential name changes.


https://reviews.llvm.org/D32404





More information about the llvm-commits mailing list