[PATCH] D32330: X86: Don't emit zero-byte functions on Windows

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 17:23:16 PDT 2017


hans created this revision.

Empty functions can lead to duplicate entries in the Guard CF Function Table of a binary due to multiple functions sharing the same RVA, causing the kernel to refuse to load that binary.

We had a terrific bug due to this in Chromium.


https://reviews.llvm.org/D32330

Files:
  lib/Target/X86/X86TargetMachine.cpp
  test/CodeGen/X86/empty-function.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32330.96064.patch
Type: text/x-patch
Size: 3629 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170421/7827c9b5/attachment.bin>


More information about the llvm-commits mailing list