[llvm] r300931 - [CodeExtractor] Remove an unneeded level of indirection. NFCI.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 17:21:09 PDT 2017


Author: davide
Date: Thu Apr 20 19:21:09 2017
New Revision: 300931

URL: http://llvm.org/viewvc/llvm-project?rev=300931&view=rev
Log:
[CodeExtractor] Remove an unneeded level of indirection. NFCI.

Modified:
    llvm/trunk/lib/Transforms/Utils/CodeExtractor.cpp

Modified: llvm/trunk/lib/Transforms/Utils/CodeExtractor.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/CodeExtractor.cpp?rev=300931&r1=300930&r2=300931&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/CodeExtractor.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/CodeExtractor.cpp Thu Apr 20 19:21:09 2017
@@ -73,12 +73,13 @@ bool CodeExtractor::isBlockValidForExtra
 }
 
 /// \brief Build a set of blocks to extract if the input blocks are viable.
-template <typename IteratorT>
-static SetVector<BasicBlock *> buildExtractionBlockSet(IteratorT BBBegin,
-                                                       IteratorT BBEnd) {
-  SetVector<BasicBlock *> Result;
+static SetVector<BasicBlock *>
+buildExtractionBlockSet(ArrayRef<BasicBlock *> BBs) {
+  auto BBBegin = BBs.begin();
+  auto BBEnd = BBs.end();
+  assert(BBBegin != BBEnd && "The set of blocks to extract must be non-empty");
 
-  assert(BBBegin != BBEnd);
+  SetVector<BasicBlock *> Result;
 
   // Loop over the blocks, adding them to our set-vector, and aborting with an
   // empty set if we encounter invalid blocks.
@@ -106,12 +107,6 @@ static SetVector<BasicBlock *> buildExtr
   return Result;
 }
 
-/// \brief Helper to call buildExtractionBlockSet with an ArrayRef.
-static SetVector<BasicBlock *>
-buildExtractionBlockSet(ArrayRef<BasicBlock *> BBs) {
-  return buildExtractionBlockSet(BBs.begin(), BBs.end());
-}
-
 CodeExtractor::CodeExtractor(ArrayRef<BasicBlock *> BBs, DominatorTree *DT,
                              bool AggregateArgs, BlockFrequencyInfo *BFI,
                              BranchProbabilityInfo *BPI)




More information about the llvm-commits mailing list