[PATCH] D32214: [XRay][compiler-rt] Cleanup CFI/CFA annotations on trampolines

Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 00:44:20 PDT 2017


kpw accepted this revision.
kpw added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/xray/xray_trampoline_x86_64.S:101
+	subq	$56, %rsp
 	.cfi_def_cfa_offset 64
+	movq  %rbp, 48(%rsp)
----------------
If the exit handler is jumped into,  does the exit sled explicitly push the return address onto the stack (accounting for the extra 8 bytes compared to the subq insn above)?


https://reviews.llvm.org/D32214





More information about the llvm-commits mailing list