[PATCH] D32214: [XRay][compiler-rt] Cleanup CFI/CFA annotations on trampolines

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 00:02:21 PDT 2017


dberris created this revision.

This is a follow-up to https://reviews.llvm.org/D32202.

While the previous change (https://reviews.llvm.org/D32202) did fix the stack alignment issue, we
were still at a weird state in terms of the CFI/CFA directives (as the
offsets were wrong). This change cleans up the SAVE/RESTORE macros for
the trampoline, accounting the stack pointer adjustments with less
instructions and with some clearer math. We note that the offsets will
be different on the exit trampolines, because we don't typically 'call'
into this trampoline and we only ever jump into them (i.e. treated as a
tail call that's patched in at runtime).


https://reviews.llvm.org/D32214

Files:
  lib/xray/xray_trampoline_x86_64.S

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32214.95691.patch
Type: text/x-patch
Size: 2808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170419/eee1af9a/attachment.bin>


More information about the llvm-commits mailing list