[PATCH] D31843: [LCSSA] Try to not walk the dominator tree more than necessary

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 19:10:38 PDT 2017


davide added a comment.

In https://reviews.llvm.org/D31843#725624, @mzolotukhin wrote:

> > The new patch is here and it's 25% faster than the unpatched version on the testcase included in the PR
>
> Nice!
>
> The patch looks good to me (not surprising probably, since I suggested the same :) ). One nitpick to consider: maybe factor out the function to compute `BlocksDominatingExits` to keep the logic of `formLCSSA` clearer.
>
> Michael


I'll wait for Dan if he has additional comments, but other than that I'd like to point out that LCSSA is still very slow ;)
I think the next thing I'll try will be hooking the new SSAUpdater as we spend a lot of time there.


https://reviews.llvm.org/D31843





More information about the llvm-commits mailing list