[PATCH] D31843: [LCSSA] Try to not walk the dominator tree more than necessary

Michael Zolotukhin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 19:04:45 PDT 2017


mzolotukhin added a comment.

> The new patch is here and it's 25% faster than the unpatched version on the testcase included in the PR

Nice!

The patch looks good to me (not surprising probably, since I suggested the same :) ). One nitpick to consider: maybe factor out the function to compute `BlocksDominatingExits` to keep the logic of `formLCSSA` clearer.

Michael


https://reviews.llvm.org/D31843





More information about the llvm-commits mailing list