[PATCH] D31930: [XRay] [compiler-rt] Simplify FDR logging handler. [NFC]

Martin Pelikán via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 01:25:15 PDT 2017


pelikan added a comment.

Ack.  I don't mean this from the "easy to test" perspective.  I want the code to be easier to read.  I don't mind tall functions as long as they're simple, and this one has quite a lot of detail on several (distinct) topics.  It deals with both types of entries, TSCs, rewinding, buffer shortages and tail call handling all at once.  It's not very pleasant for me to keep scrolling such a large amount of code on the screen, that's all.

Motivation for what exactly is no longer as important?


https://reviews.llvm.org/D31930





More information about the llvm-commits mailing list