[PATCH] D31930: [XRay] [compiler-rt] Simplify FDR logging handler. [NFC]

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 00:49:10 PDT 2017


dberris added a comment.

LGTM

Just FYI: I and @kpw thought the current state would be a good compromise to being able to start writing more granular unit tests. I think we can think about alternative ways of doing testing involving more end-to-end tests now that we can do FDR tests with the lit infrastructure, so the original motivation for this is no longer as important.


https://reviews.llvm.org/D31930





More information about the llvm-commits mailing list