[llvm] r299258 - [Hexagon] Fix typo in HexagonEarlyIfCConv.cpp

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 1 09:33:12 PDT 2017


any chance it's worth refactoring the FaseB and TrueB branches to a common
(potentially local lambda) function?

On Fri, Mar 31, 2017 at 1:48 PM Krzysztof Parzyszek via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: kparzysz
> Date: Fri Mar 31 15:36:00 2017
> New Revision: 299258
>
> URL: http://llvm.org/viewvc/llvm-project?rev=299258&view=rev
> Log:
> [Hexagon] Fix typo in HexagonEarlyIfCConv.cpp
>
> Found by PVS-Studio. Fixes llvm.org/PR32480.
>
> Modified:
>     llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp
>     llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll
>
> Modified: llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp?rev=299258&r1=299257&r2=299258&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp (original)
> +++ llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp Fri Mar 31
> 15:36:00 2017
> @@ -546,7 +546,7 @@ bool HexagonEarlyIfConversion::isProfita
>    if (FP.FalseB) {
>      FS = std::distance(FP.FalseB->begin(),
> FP.FalseB->getFirstTerminator());
>      if (FS < HEXAGON_PACKET_SIZE)
> -      Spare += HEXAGON_PACKET_SIZE-TS;
> +      Spare += HEXAGON_PACKET_SIZE-FS;
>    }
>    unsigned TotalIn = TS+FS;
>    DEBUG(dbgs() << "Total number of instructions to be
> predicated/speculated: "
>
> Modified: llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll?rev=299258&r1=299257&r2=299258&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll
> (original)
> +++ llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll Fri
> Mar 31 15:36:00 2017
> @@ -1,4 +1,4 @@
> -; RUN: llc -march=hexagon -o - %s | FileCheck %s
> +; RUN: llc -march=hexagon -hexagon-eif=0 < %s | FileCheck %s
>  target triple = "hexagon"
>
>  %struct.0 = type { i16, i16 }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170401/b307d66c/attachment.html>


More information about the llvm-commits mailing list