<div dir="ltr">any chance it's worth refactoring the FaseB and TrueB branches to a common (potentially local lambda) function?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 31, 2017 at 1:48 PM Krzysztof Parzyszek via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kparzysz<br class="gmail_msg">
Date: Fri Mar 31 15:36:00 2017<br class="gmail_msg">
New Revision: 299258<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=299258&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=299258&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[Hexagon] Fix typo in HexagonEarlyIfCConv.cpp<br class="gmail_msg">
<br class="gmail_msg">
Found by PVS-Studio. Fixes <a href="http://llvm.org/PR32480" rel="noreferrer" class="gmail_msg" target="_blank">llvm.org/PR32480</a>.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp<br class="gmail_msg">
    llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp?rev=299258&r1=299257&r2=299258&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp?rev=299258&r1=299257&r2=299258&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Target/Hexagon/HexagonEarlyIfConv.cpp Fri Mar 31 15:36:00 2017<br class="gmail_msg">
@@ -546,7 +546,7 @@ bool HexagonEarlyIfConversion::isProfita<br class="gmail_msg">
   if (FP.FalseB) {<br class="gmail_msg">
     FS = std::distance(FP.FalseB->begin(), FP.FalseB->getFirstTerminator());<br class="gmail_msg">
     if (FS < HEXAGON_PACKET_SIZE)<br class="gmail_msg">
-      Spare += HEXAGON_PACKET_SIZE-TS;<br class="gmail_msg">
+      Spare += HEXAGON_PACKET_SIZE-FS;<br class="gmail_msg">
   }<br class="gmail_msg">
   unsigned TotalIn = TS+FS;<br class="gmail_msg">
   DEBUG(dbgs() << "Total number of instructions to be predicated/speculated: "<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll?rev=299258&r1=299257&r2=299258&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll?rev=299258&r1=299257&r2=299258&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll (original)<br class="gmail_msg">
+++ llvm/trunk/test/CodeGen/Hexagon/ifcvt-diamond-bug-2016-08-26.ll Fri Mar 31 15:36:00 2017<br class="gmail_msg">
@@ -1,4 +1,4 @@<br class="gmail_msg">
-; RUN: llc -march=hexagon -o - %s | FileCheck %s<br class="gmail_msg">
+; RUN: llc -march=hexagon -hexagon-eif=0 < %s | FileCheck %s<br class="gmail_msg">
 target triple = "hexagon"<br class="gmail_msg">
<br class="gmail_msg">
 %struct.0 = type { i16, i16 }<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>