[llvm] r298726 - Make testcase less nonsensical while still exercising the same code paths.

[David Blaikie via llvm-commits]

some comments on the location expressions (writing out which operations
they are, etc) might be nice.

On Fri, Mar 24, 2017 at 12:23 PM Adrian Prantl via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: adrian
> Date: Fri Mar 24 14:11:31 2017
> New Revision: 298726
>
> URL: http://llvm.org/viewvc/llvm-project?rev=298726&view=rev
> Log:
> Make testcase less nonsensical while still exercising the same code paths.
>
> Modified:
>     llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll
>
> Modified: llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll?rev=298726&r1=298725&r2=298726&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll (original)
> +++ llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll Fri Mar 24
> 14:11:31 2017
> @@ -1,38 +1,42 @@
>  ; RUN: llc -o - %s | FileCheck --check-prefix=CHECK-DWARF2 %s
>  ; RUN: llc -dwarf-version=4 -o - %s | FileCheck
> --check-prefix=CHECK-DWARF4 %s
>
> +; Exercise DW_OP_stack_value on global constants.
> +
>  target datalayout = "e-p:64:64"
>  target triple = "x86_64-unknown-linux-gnu"
>
> -; CHECK-DWARF2:      .byte     13                      # DW_AT_location
> -; CHECK-DWARF2-NEXT: .byte     3
> -; CHECK-DWARF2-NEXT: .quad     g
> -; CHECK-DWARF2-NEXT: .byte     16
> -; CHECK-DWARF2-NEXT: .byte     4
> -; CHECK-DWARF2-NEXT: .byte     16
> -; CHECK-DWARF2-NEXT: .byte     4
> -
> -; CHECK-DWARF4:      .byte     14                      # DW_AT_location
> -; CHECK-DWARF4-NEXT: .byte     3
> -; CHECK-DWARF4-NEXT: .quad     g
> -; CHECK-DWARF4-NEXT: .byte     16
> -; CHECK-DWARF4-NEXT: .byte     4
> -; CHECK-DWARF4-NEXT: .byte     16
> -; CHECK-DWARF4-NEXT: .byte     4
> -; CHECK-DWARF4-NEXT: .byte     159
> -
> - at g = global i32 0, !dbg !2
> +; CHECK-DWARF2: .byte  8                       # DW_AT_location
> +; CHECK-DWARF2 .byte   16
> +; CHECK-DWARF2 .byte   4
> +; CHECK-DWARF2 .byte   147
> +; CHECK-DWARF2 .byte   2
> +; CHECK-DWARF2 .byte   16
> +; CHECK-DWARF2 .byte   0
> +; CHECK-DWARF2 .byte   147
> +; CHECK-DWARF2 .byte   2
> +
> +; CHECK-DWARF4:       .byte    10                      # DW_AT_location
> +; CHECK-DWARF4-NEXT:  .byte    16
> +; CHECK-DWARF4-NEXT:  .byte    4
> +; CHECK-DWARF4-NEXT:  .byte    159
> +; CHECK-DWARF4-NEXT:  .byte    147
> +; CHECK-DWARF4-NEXT:  .byte    2
> +; CHECK-DWARF4-NEXT:  .byte    16
> +; CHECK-DWARF4-NEXT:  .byte    0
> +; CHECK-DWARF4-NEXT:  .byte    159
>
>  !0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, producer:
> "clang", file: !4, globals: !1, emissionKind: FullDebug)
> -!1 = !{!2}
> +!1 = !{!2, !10}
>  !2 = !DIGlobalVariableExpression(var: !8, expr: !3)
> -!3 = !DIExpression(DW_OP_constu, 4, DW_OP_constu, 4, DW_OP_stack_value)
> +!3 = !DIExpression(DW_OP_constu, 4, DW_OP_stack_value,
> DW_OP_LLVM_fragment, 0, 16)
>  !4 = !DIFile(filename: "<stdin>", directory: "/")
>  !5 = !DIBasicType(name: "int", size: 32, align: 32, encoding:
> DW_ATE_signed)
> -
>  !6 = !{i32 2, !"Dwarf Version", i32 2}
>  !7 = !{i32 2, !"Debug Info Version", i32 3}
>  !8 = distinct !DIGlobalVariable(name: "a", scope: null, isLocal: false,
> isDefinition: true, type: !5)
> +!9 = !DIExpression(DW_OP_constu, 0, DW_OP_stack_value,
> DW_OP_LLVM_fragment, 16, 16)
> +!10 = !DIGlobalVariableExpression(var: !8, expr: !9)
>
>  !llvm.dbg.cu = !{!0}
>  !llvm.module.flags = !{!6, !7}
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170327/b104bef7/attachment-0001.html>