<div dir="ltr">some comments on the location expressions (writing out which operations they are, etc) might be nice.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 24, 2017 at 12:23 PM Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br class="gmail_msg">
Date: Fri Mar 24 14:11:31 2017<br class="gmail_msg">
New Revision: 298726<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=298726&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=298726&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Make testcase less nonsensical while still exercising the same code paths.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll?rev=298726&r1=298725&r2=298726&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll?rev=298726&r1=298725&r2=298726&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll (original)<br class="gmail_msg">
+++ llvm/trunk/test/DebugInfo/X86/stack-value-dwarf4.ll Fri Mar 24 14:11:31 2017<br class="gmail_msg">
@@ -1,38 +1,42 @@<br class="gmail_msg">
 ; RUN: llc -o - %s | FileCheck --check-prefix=CHECK-DWARF2 %s<br class="gmail_msg">
 ; RUN: llc -dwarf-version=4 -o - %s | FileCheck --check-prefix=CHECK-DWARF4 %s<br class="gmail_msg">
<br class="gmail_msg">
+; Exercise DW_OP_stack_value on global constants.<br class="gmail_msg">
+<br class="gmail_msg">
 target datalayout = "e-p:64:64"<br class="gmail_msg">
 target triple = "x86_64-unknown-linux-gnu"<br class="gmail_msg">
<br class="gmail_msg">
-; CHECK-DWARF2:      .byte     13                      # DW_AT_location<br class="gmail_msg">
-; CHECK-DWARF2-NEXT: .byte     3<br class="gmail_msg">
-; CHECK-DWARF2-NEXT: .quad     g<br class="gmail_msg">
-; CHECK-DWARF2-NEXT: .byte     16<br class="gmail_msg">
-; CHECK-DWARF2-NEXT: .byte     4<br class="gmail_msg">
-; CHECK-DWARF2-NEXT: .byte     16<br class="gmail_msg">
-; CHECK-DWARF2-NEXT: .byte     4<br class="gmail_msg">
-<br class="gmail_msg">
-; CHECK-DWARF4:      .byte     14                      # DW_AT_location<br class="gmail_msg">
-; CHECK-DWARF4-NEXT: .byte     3<br class="gmail_msg">
-; CHECK-DWARF4-NEXT: .quad     g<br class="gmail_msg">
-; CHECK-DWARF4-NEXT: .byte     16<br class="gmail_msg">
-; CHECK-DWARF4-NEXT: .byte     4<br class="gmail_msg">
-; CHECK-DWARF4-NEXT: .byte     16<br class="gmail_msg">
-; CHECK-DWARF4-NEXT: .byte     4<br class="gmail_msg">
-; CHECK-DWARF4-NEXT: .byte     159<br class="gmail_msg">
-<br class="gmail_msg">
-@g = global i32 0, !dbg !2<br class="gmail_msg">
+; CHECK-DWARF2: .byte  8                       # DW_AT_location<br class="gmail_msg">
+; CHECK-DWARF2 .byte   16<br class="gmail_msg">
+; CHECK-DWARF2 .byte   4<br class="gmail_msg">
+; CHECK-DWARF2 .byte   147<br class="gmail_msg">
+; CHECK-DWARF2 .byte   2<br class="gmail_msg">
+; CHECK-DWARF2 .byte   16<br class="gmail_msg">
+; CHECK-DWARF2 .byte   0<br class="gmail_msg">
+; CHECK-DWARF2 .byte   147<br class="gmail_msg">
+; CHECK-DWARF2 .byte   2<br class="gmail_msg">
+<br class="gmail_msg">
+; CHECK-DWARF4:       .byte    10                      # DW_AT_location<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    16<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    4<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    159<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    147<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    2<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    16<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    0<br class="gmail_msg">
+; CHECK-DWARF4-NEXT:  .byte    159<br class="gmail_msg">
<br class="gmail_msg">
 !0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, producer: "clang", file: !4, globals: !1, emissionKind: FullDebug)<br class="gmail_msg">
-!1 = !{!2}<br class="gmail_msg">
+!1 = !{!2, !10}<br class="gmail_msg">
 !2 = !DIGlobalVariableExpression(var: !8, expr: !3)<br class="gmail_msg">
-!3 = !DIExpression(DW_OP_constu, 4, DW_OP_constu, 4, DW_OP_stack_value)<br class="gmail_msg">
+!3 = !DIExpression(DW_OP_constu, 4, DW_OP_stack_value, DW_OP_LLVM_fragment, 0, 16)<br class="gmail_msg">
 !4 = !DIFile(filename: "<stdin>", directory: "/")<br class="gmail_msg">
 !5 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)<br class="gmail_msg">
-<br class="gmail_msg">
 !6 = !{i32 2, !"Dwarf Version", i32 2}<br class="gmail_msg">
 !7 = !{i32 2, !"Debug Info Version", i32 3}<br class="gmail_msg">
 !8 = distinct !DIGlobalVariable(name: "a", scope: null, isLocal: false, isDefinition: true, type: !5)<br class="gmail_msg">
+!9 = !DIExpression(DW_OP_constu, 0, DW_OP_stack_value, DW_OP_LLVM_fragment, 16, 16)<br class="gmail_msg">
+!10 = !DIGlobalVariableExpression(var: !8, expr: !9)<br class="gmail_msg">
<br class="gmail_msg">
 !<a href="http://llvm.dbg.cu" rel="noreferrer" class="gmail_msg" target="_blank">llvm.dbg.cu</a> = !{!0}<br class="gmail_msg">
 !llvm.module.flags = !{!6, !7}<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>