[PATCH] D31263: Add option to control whether llvm-pdbdump outputs in color

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 03:12:37 PDT 2017

chandlerc added a comment.

In https://reviews.llvm.org/D31263#708137, @amccarth wrote:

> In https://reviews.llvm.org/D31263#708121, @zturner wrote:
> > I think we need something before you commit, because as it is people will be specifying `--color-output` unnecessarily.  Even if you say "default = on" or "default = best-effort"
> OK, I came up with "Override use of color (default = isatty)", which I assume should be clear enough for typical users of this tool.
> I'll let it bake tonight and submit in the morning, in case Chandler or anyone else has additional ideas.

I have no better suggestion. Thanks for reworking with this approach though! =D


More information about the llvm-commits mailing list