[PATCH] D31263: Add option to control whether llvm-pdbdump outputs in color

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 15:42:37 PDT 2017

amccarth marked an inline comment as done.
amccarth added a comment.

In https://reviews.llvm.org/D31263#708121, @zturner wrote:

> I think we need something before you commit, because as it is people will be specifying `--color-output` unnecessarily.  Even if you say "default = on" or "default = best-effort"

OK, I came up with "Override use of color (default = isatty)", which I assume should be clear enough for typical users of this tool.

I'll let it bake tonight and submit in the morning, in case Chandler or anyone else has additional ideas.


More information about the llvm-commits mailing list