[PATCH] D31239: [WIP] Add Caching of Known Bits in InstCombine

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 14:53:08 PDT 2017

hfinkel added a comment.

In https://reviews.llvm.org/D31239#707970, @rnk wrote:

> We can't just keep passing more analysis pointers throughout our simplification utilities. We might want some wrapper of common, almost globally used analyses that optionally contains DL, TLI, DT, AC, etc.

We definitely should. Actually, this may really just remove code. computeKnownBits's implementation uses a Query structure to contain these, so does InstructionSimplify. It is only the external interfaces that are unwieldy.  We might promote these Query structures somehow and then just make the internal interfaces the external ones.


More information about the llvm-commits mailing list