[PATCH] D31211: [AMDGPU] Add target triple environment amdnas and amdnascl

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 12:35:34 PDT 2017


arsenm added inline comments.


================
Comment at: include/llvm/ADT/Triple.h:202-203
     OpenCL,
-    LastEnvironmentType = OpenCL
+    AMDNAS,
+    AMDNASCL,
+    LastEnvironmentType = AMDNASCL,
----------------
I don't think we should be adding new entries for a temporary step. I think the triple still preserves whatever you give it, so can you check getEnvironmentName()?


https://reviews.llvm.org/D31211





More information about the llvm-commits mailing list