[compiler-rt] r297995 - [PowerPC] Fix sanitizer frame unwind on 32-bit ABIs

[Kostya Serebryany via llvm-commits]

On Mon, Mar 20, 2017 at 9:07 AM, Bill Seurer <seurer at linux.vnet.ibm.com>
wrote:

> On 03/16/2017 04:38 PM, Kostya Serebryany wrote:
>
>> Hi Bill,
>>
>> * Has this been code-reviewed? In general, please do pre-commit code
>> reviews for any code that is common between Power and other platforms.
>>
>
> This came from a gcc developer.  I submitted the patch here at his request.


Please try to avoid this in future. The upstream is LLVM repo, not GCC
repo,
so any code going into LLVM needs to be reviewed (at least if the committer
is not a code owner)

--kcc

>
>
> Even if (or: especially if) there are #ifdefs involved. (I hate #ifdefs)
>> * Is there any chance to get rid of #ifdefs and replace them with if()?
>> Or maybe just a separate implementation for Power?
>>
>
> The code is already #ifed for power but I will ask the developer.
>
> * do the existing tests cover the problems that this change solves?
>>
>
> The patch was to fix existing problems for 32 bit code that the existing
> tests cover.
> --
>
> -Bill Seurer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170320/081329b3/attachment.html>