[compiler-rt] r297995 - [PowerPC] Fix sanitizer frame unwind on 32-bit ABIs
Bill Seurer via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 20 09:07:51 PDT 2017
On 03/16/2017 04:38 PM, Kostya Serebryany wrote:
> Hi Bill,
> * Has this been code-reviewed? In general, please do pre-commit code
> reviews for any code that is common between Power and other platforms.
This came from a gcc developer. I submitted the patch here at his request.
> Even if (or: especially if) there are #ifdefs involved. (I hate #ifdefs)
> * Is there any chance to get rid of #ifdefs and replace them with if()?
> Or maybe just a separate implementation for Power?
The code is already #ifed for power but I will ask the developer.
> * do the existing tests cover the problems that this change solves?
The patch was to fix existing problems for 32 bit code that the existing
More information about the llvm-commits