[PATCH] D31081: [ARM] ScheduleDAGRRList::DelayForLiveRegsBottomUp must consider OptionalDefs

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 11:52:15 PDT 2017


efriedma added a comment.

I didn't realize the Thumb1 instructions weren't marked up correctly. :(  Please revert https://reviews.llvm.org/D30400 until this is fixed.

This isn't really the right fix; each Thumb1 instruction should either have CPSR as an explicit Def, or list it in ImplicitDefs.  Adding the additional check for optional defs might solve your problem here, sort of, but we check for ImplicitDefs in a lot of places, so it's better to get it right.


https://reviews.llvm.org/D31081





More information about the llvm-commits mailing list