[PATCH] D30747: TargetInstrInfo: Provide default implementation of isTailCall().

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 16:46:40 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D30747#702358, @dberris wrote:

> In https://reviews.llvm.org/D30747#702343, @MatzeB wrote:
>
> > In https://reviews.llvm.org/D30747#702333, @dberris wrote:
> >
> > > LGTM -- I suspect this doesn't break the compiler-rt tests for XRay?
> >
> >
> > Can I even run them on a mac? I also don't have PPC hardware available. But we surely have buildbots for that (and if not I blame someone else for the lack of bots).
>
>
> Nope, the XRay runtime doesn't work in MacOS yet.
>
> There are bots that run these. I'm not sure if you want to wait to find out if they break. :)


Unless you run them for me that's all I can do. Reverts are cheap (breaking the build isn't so nice but as long as we don't have pre-commit checking in llvm...).


Repository:
  rL LLVM

https://reviews.llvm.org/D30747





More information about the llvm-commits mailing list