[PATCH] D30747: TargetInstrInfo: Provide default implementation of isTailCall().

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D30747#702343, @MatzeB wrote:

> In https://reviews.llvm.org/D30747#702333, @dberris wrote:
>
> > LGTM -- I suspect this doesn't break the compiler-rt tests for XRay?
>
>
> Can I even run them on a mac? I also don't have PPC hardware available. But we surely have buildbots for that (and if not I blame someone else for the lack of bots).


Nope, the XRay runtime doesn't work in MacOS yet.

There are bots that run these. I'm not sure if you want to wait to find out if they break. :)



================
Comment at: include/llvm/Target/TargetInstrInfo.h:1499-1501
+  /// Determines whether \p Inst is a tail call instruction. There is no need to
+  /// override this method, unless the target doesn't model the isCall/isReturn
+  /// flags correctly!
----------------
MatzeB wrote:
> dberris wrote:
> > Can we make this comment more direct? Something like:
> > 
> > "Override this method for targets where tail calls are not always both return and call instructions."
> Ok how about
> 
> "Override this method on targets that do not properly set MCID::Return and MCID::Call on tail call instructions."
> 
> to not give the impression that this is recommended.
That's better I think.


Repository:
  rL LLVM

https://reviews.llvm.org/D30747