[PATCH] D30049: x86 interrupt calling convention: re-align stack pointer on 64-bit if an error code was pushed

Philipp Oppermann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 08:24:18 PDT 2017


phil-opp added inline comments.


================
Comment at: test/CodeGen/X86/x86-64-intrcc.ll:33
   ; CHECK: pushq %rax
+  ; CHECK: pushq %rax
   ; CHECK: pushq %rcx
----------------
aaboud wrote:
> I am wondering if this push was not generated before your last fix?
> Did you just forget to update the test? or we needed the last change to have this push?
I just forgot to update this test, because it still succeeded (it's only a `CHECK` and not a `CHECK-NEXT`). However, by adding the additional check we ensure that the stack alignment isn't removed accidentally in the future.


https://reviews.llvm.org/D30049





More information about the llvm-commits mailing list