[PATCH] D30049: x86 interrupt calling convention: re-align stack pointer on 64-bit if an error code was pushed

[Amjad Aboud via Phabricator via llvm-commits]

aaboud added a comment.

Code looks good, but I am wondering about one thing, see below.



================
Comment at: test/CodeGen/X86/x86-64-intrcc.ll:33
   ; CHECK: pushq %rax
+  ; CHECK: pushq %rax
   ; CHECK: pushq %rcx
----------------
I am wondering if this push was not generated before your last fix?
Did you just forget to update the test? or we needed the last change to have this push?


================
Comment at: test/CodeGen/X86/x86-64-intrcc.ll:35
   ; CHECK: pushq %rcx
-  ; CHECK: movq 16(%rsp), %rax
-  ; CHECK: movq 40(%rsp), %rcx
+  ; CHECK: movq 24(%rsp), %rax
+  ; CHECK: movq 48(%rsp), %rcx
----------------
This is a good catch.
Indeed we should update the argument offsets after we re-align the stack with +8 bytes.


https://reviews.llvm.org/D30049