[PATCH] D30944: [ELF] - Detemplate GotPltSection and IgotPltSection sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 02:23:13 PDT 2017


grimar added inline comments.


================
Comment at: ELF/Config.h:166
+  // Returns true if target is 64 bit.
+  bool is64() const { return EKind == ELF64LEKind || EKind == ELF64BEKind; }
+
----------------
ruiu wrote:
> grimar wrote:
> > jhenderson wrote:
> > > Could this be is64Bit()?
> > yes, thats better.
> I think I actually prefer is64 over is64Bits.
It seems is64Bit() is much more consistent with LLVM code.
is64() used 17 times (mostly  LLD/COFF) vs is64Bits() used 587 times.

Still want me to rename it ?


https://reviews.llvm.org/D30944





More information about the llvm-commits mailing list