[PATCH] D30944: [ELF] - Detemplate GotPltSection and IgotPltSection sections.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Config.h:166
+  // Returns true if target is 64 bit.
+  bool is64() const { return EKind == ELF64LEKind || EKind == ELF64BEKind; }
+
----------------
grimar wrote:
> jhenderson wrote:
> > Could this be is64Bit()?
> yes, thats better.
I think I actually prefer is64 over is64Bits.


================
Comment at: ELF/Config.h:183
   bool isRela() const {
-    bool is64 = (EKind == ELF64LEKind || EKind == ELF64BEKind);
     bool isX32Abi = (EKind == ELF32LEKind && EMachine == llvm::ELF::EM_X86_64);
+    return is64Bit() || isX32Abi || MipsN32Abi;
----------------
While you are here, can you capitalize is -> Is?


https://reviews.llvm.org/D30944