[PATCH] archives require a symbol table on Solaris, even if empty

Danek Duvall via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 11:03:07 PST 2017


James Henderson wrote:

> I noticed when looking at this that the writeSymbolTable does not write
> anything if there are no archive members at all, even after this patch (see
> the early return on line 331). I would think that if a caller has requested
> a symbol table we should write one, even if it is for an empty archive, but
> that perhaps is a different discussion. Do your tools care about a missing
> symbol table if the archive is completely empty?

The linker cares, but not as much -- it emits a warning and ignores it.

Danek


More information about the llvm-commits mailing list