[PATCH] archives require a symbol table on Solaris, even if empty

[James Henderson via llvm-commits]

I noticed when looking at this that the writeSymbolTable does not write
anything if there are no archive members at all, even after this patch (see
the early return on line 331). I would think that if a caller has requested
a symbol table we should write one, even if it is for an empty archive, but
that perhaps is a different discussion. Do your tools care about a missing
symbol table if the archive is completely empty?

James

On 8 March 2017 at 07:23, Davide Italiano via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Tue, Mar 7, 2017 at 2:38 PM, Danek Duvall via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > I ran into this bug with the Solaris linker where ld (and some other
> tools
> > that use the underlying utility libraries, such as elfdump) chokes on an
> > archive library that has no symbol table.  Our tools always create one,
> > even if it's empty.
> >
> > That bug has been fixed in the latest development line, and can probably
> be
> > backported to a supported release, but it would be nice if LLVM's
> archiver
> > could emit the empty symbol table, too.
> >
> > I've attached a patch that has been working for me in the context of the
> > copy of LLVM in the Rust project, though I've regenerated the patch
> against
> > SVN, just to be sure.
> >
> > Let me know if there's any other process I need to follow to get this
> patch
> > landed.
> >
> > Thanks,
> > Danek
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
>
> I have no strong objections about this, but I may miss something so,
> cc:ing Rafael.
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170308/e146496f/attachment.html>