[PATCH] D30612: [APInt] Add rvalue reference support to and, or, xor operations to allow their memory allocation to be reused when possible

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 5 08:29:53 PST 2017


craig.topper added a comment.

Removing the And, Or, Xor functions could be removed separately.

The change to getBitsSet and intersects were necessary because of the operator functions being moved out of line. But they could be done as a pre-patch.

I hadn't looked at the move constructor. I was basing this on r276470 and assuming it was ok. Should I change it to use memcpy like the move assignment operator?


https://reviews.llvm.org/D30612





More information about the llvm-commits mailing list