[PATCH] D30612: [APInt] Add rvalue reference support to and, or, xor operations to allow their memory allocation to be reused when possible

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 5 07:58:14 PST 2017


dblaikie added a comment.

Are the cleanup changes (removing unused operations, etc) tied to the main change here, or could they be done separately?

Also, it looks like the main change could be tested by using getRawData to demonstrate that the moves rather than copies happened, maybe?

(that said, the move ctor looks questionable - it copies a possibly inactive member of a union & relies on that to copy the other member of the union)


https://reviews.llvm.org/D30612





More information about the llvm-commits mailing list